Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port]Game presets can now have cooldowns to prevent back-to-back modes #2744

Merged
merged 8 commits into from
Jan 19, 2025
Merged

[Port]Game presets can now have cooldowns to prevent back-to-back modes #2744

merged 8 commits into from
Jan 19, 2025
+43 −0

Conversation

Lyndomen
Copy link
Contributor

@Lyndomen Lyndomen commented Jan 15, 2025 •
edited
Loading

About the PR

add stuff from Impstation that makes it so we cant roll nukies twice in a row :trollface: did similar for survival, now you can only have 4 hours of vent critters not 10

Why / Balance

gamemodes bad

Technical details

port

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

🆑 TGRCDev, Lyndomen

  • add: Gamemodes now have cooldowns to prevent back-to-back modes. Modes that have been voted on are exempt from this.

@Lyndomen Lyndomen requested review from a team as code owners January 15, 2025 19:26
@github-actions github-actions bot added S: Needs Review size/S 16-63 lines Changes: YML Changes any yml files Changes: C# Changes any cs files labels Jan 15, 2025
@Lyndomen
Copy link
Contributor Author

Lyndomen commented Jan 15, 2025 •
edited
Loading

fixes #2737
well, it half fixes it

Radezolid
Radezolid requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor requests from me

Resources/Prototypes/game_presets.yml Outdated Show resolved Hide resolved
Resources/Prototypes/game_presets.yml Outdated Show resolved Hide resolved
@Lyndomen
Update game_presets.yml
569aa0a 
i hate whitespace

Signed-off-by: Lyndomen <[email protected]>
@Lyndomen
Update GamePresetPrototype.cs
810cc41 
Signed-off-by: Lyndomen <[email protected]>
@Lyndomen
Copy link
Contributor Author

idk if test fail real

Radezolid
Radezolid previously approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The three lines of YAML look good.

deltanedas
deltanedas previously approved these changes Jan 15, 2025
View reviewed changes
@deltanedas
Copy link
Member

deltanedas commented Jan 15, 2025 •
edited
Loading

just need to disable this logic for tests (add a cvar probably)

@Lyndomen
Update game_presets.yml
83efcc7 
Signed-off-by: Lyndomen <[email protected]>
@Lyndomen Lyndomen dismissed stale reviews from deltanedas and Radezolid via 83efcc7 January 16, 2025 14:13
Lyndomen
Lyndomen commented Jan 16, 2025
View reviewed changes
Copy link
Contributor Author

@Lyndomen Lyndomen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok direction approved

@deltanedas
Copy link
Member

still need to disable this logic for tests

@LadyDanger2743
Copy link

If there's anything that can be done to expedite the process of this PR, let me know. We have had SIX back-to-back NukeOps rounds today on Apoapsis; it's starting to get to folks.

@deltanedas
Copy link
Member

this still needs a cvar to not break tests

@Lyndomen
Copy link
Contributor Author

this still needs a cvar to not break tests

Yes I'll build it when I'm home in like 2 hours or ready up for nukies 12345

@Lyndomen Lyndomen requested a review from deltanedas January 18, 2025 04:24
@Lyndomen
Copy link
Contributor Author

ok maybe real, would appreciate help. this ran in my local env, and doesnt error but this is my first cvar

@fow111
Copy link

fow111 commented Jan 18, 2025

Wouldn't people be like "oh damn what a nice nukie round, gotta make sure to not play sec/at all next two rounds!"?

@deltanedas
Copy link
Member

do you think people want to play sec after 5 nukies rounds in a row

@fow111
Copy link

fow111 commented Jan 18, 2025

Ye

@Lyndomen
Copy link
Contributor Author

Wouldn't people be like "oh damn what a nice nukie round, gotta make sure to not play sec/at all next two rounds!"?

Metagamers can already download cheats, and terminal gamers can sus out the game mode in 25 minutes

Qol for everyone > shitters

@Lyndomen Lyndomen requested a review from deltanedas January 19, 2025 00:19
@Lyndomen
Copy link
Contributor Author

thank you deltanedas

@deltanedas deltanedas enabled auto-merge (squash) January 19, 2025 00:20
@deltanedas deltanedas merged commit 6cf83b3 into DeltaV-Station:master Jan 19, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas approved these changes

@Radezolid Radezolid Radezolid left review comments

Assignees
No one assigned
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files S: Needs Review size/S 16-63 lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Lyndomen @deltanedas @LadyDanger2743 @fow111 @Radezolid